inlining: stop passing SemiConcreteResult to inlining_policy
#52064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/semi-concrete-inlining-policy
branch
from
86536a9 to
aee4b87
Compare
Member
Author
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
It feels a bit inconsistent that the `src` argument of `inlining_policy` needs to handle `SemiConcreteResult` while it doesn't need to handle the other container objects that propagates sources like `CodeInstance` `InferenceResult`, or `VolatileInferenceResult`. This commit makes `inlining_policy` take `result.ir::IRCode` instead when dealing with `result::SemiConcreteResult` for more consistency and clarity.
aviatesk
force-pushed
the
avi/semi-concrete-inlining-policy
branch
from
aee4b87 to
a77613e
Compare
Member
Author
|
Going to merge this as this cleans up the inlining algorithm fair bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels a bit inconsistent that the
srcargument ofinlining_policyneeds to handleSemiConcreteResultwhile it doesn't need to handle the other container objects that propagates sources likeCodeInstanceInferenceResult, orVolatileInferenceResult.This commit makes
inlining_policytakeresult.ir::IRCodeinstead when dealing withresult::SemiConcreteResultfor more consistency and clarity.@nanosoldier
runbenchmarks("inference", vs=":master")