Skip to content

combine reduce_empty methods for Union{} eltypes #51948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

combine reduce_empty methods for Union{} eltypes #51948

merged 1 commit into from
Dec 11, 2023

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 30, 2023

With #49470, these can all be dispatched to the same method now, avoiding unnecessary code duplication for this case.

@vtjnash vtjnash requested a review from JeffBezanson October 30, 2023 20:43
@vtjnash vtjnash force-pushed the jn/reduce_empty_bottom branch from 570170a to 6d11fd3 Compare October 30, 2023 21:06
@vtjnash vtjnash force-pushed the jn/reduce_empty_bottom branch 2 times, most recently from 4f92fe5 to f34931d Compare November 2, 2023 21:16
@vtjnash
Copy link
Member Author

vtjnash commented Nov 3, 2023 •
edited
Loading

Waiting on JuliaStats/Statistics.jl#156

@vtjnash
combine reduce_empty methods for Union{} eltypes
75c4eff 
With #49470, these can all be dispatched to the same method now,
avoiding unnecessary code duplication for this case.

This partly reverts f2dcc44, but our
edges against methods should be better than the ones against
MethodError these days.
@vtjnash vtjnash force-pushed the jn/reduce_empty_bottom branch from f34931d to 75c4eff Compare December 8, 2023 19:42
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Dec 8, 2023
@vtjnash vtjnash merged commit b71523e into master Dec 11, 2023
@vtjnash vtjnash deleted the jn/reduce_empty_bottom branch December 11, 2023 17:36
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vtjnash @aviatesk @oscardssmith