-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add NotImplementedError
, reduce reliance on MethodError
in Base
#51873
Draft
BioTurboNick
wants to merge
16
commits into
JuliaLang:master
Choose a base branch
from
BioTurboNick:notimplementederror
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenhinkeller
added
the
error handling
Handling of exceptions by Julia or the user
label
Oct 26, 2023
Implements #7512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from @Seelengrab 's suggestion in #50196 and my comment, I whipped up an implementation of it, also moving a subset of
MethodErrors
thrown from placeholder methods to this newNotImplementedError
.The error shares some code with MethodError, except where MethodError indicates a failure of dispatch, NotImplementedError indicates that dispatch succeeded, but either that a more specific implementation is expected and required.
As part of this draft PR, I've started moving instances of Base using
MethodError
for non-dispatch failures, with the following understanding (a few I was unsure of):convert
)zero(Any)
)There will be a lot of documentation to change around this if it's accepted.