Document and export Base.in!
#51636
Merged
Document and export Base.in!
#51636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobnissen
added
needs tests
|
Great find - The name feels incomplete for what it does, but given operations on containers generally return the container, having something different makes sense. Unless there should (also?) be a method should return a tuple of the set and whether the value was already present or not. No strong opinions here, just some thoughts. I'd like having the operation available. |
|
Comes from #45156 with some initial discussion. |
petvana
reviewed
Oct 9, 2023
Let's hope it makes it into 1.11 ! Co-authored-by: Petr Vana <petvana@centrum.cz>
jakobnissen
added
the
awaiting review
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Dec 9, 2023
I think `in!` is a useful general function for users, and would be good to have as official API. Its semantics is clear and unambiguous, while providing a clear performance advantage over the naive implementation. For more evidence that this functionality is useful, consider: * Rust's `HashSet::insert` works just like this implementation of `in!` * This function was already used in the implementation of `Base.unique`, precisely for the performance over the naive approach Comes from JuliaLang#45156 with some initial discussion.
inkydragon
removed
the
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
in!is a useful general function for users, and would be good to have as official API. Its semantics is clear and unambiguous, while providing a clear performance advantage over the naive implementation.For more evidence that this functionality is useful, consider:
HashSet::insertworks just like this implementation ofin!Base.unique, precisely for the performance over the naive approachThis PR currently doesn't have any tests - I will add them if the API addition of PR is approved.