smarter path completions in REPL shell mode #51544
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added
REPL
simeonschaub
force-pushed
the
sds/shell_complete
branch
from
1fbdf97 to
5505443
Compare
simeonschaub
force-pushed
the
sds/shell_complete
branch
from
5505443 to
d4b0283
Compare
Uses the fancy new inference-based completion infrastructure to complete expressions like `ls $(DEPOT_PATH[1])/<tab>` in the REPL shell. Currently doesn't extend to path completions for cmd and string literals in the normal REPL mode, but that shouldn't be too hard to add. Still needs tests
simeonschaub
force-pushed
the
sds/shell_complete
branch
from
d4b0283 to
f2403e0
Compare
|
This sounds like a really nice addition, I'd love to have this. But by now there are a bunch of merge conflicts (and I guess it still needs tests ;-) ). Do you have any plans to continue this, @simeonschaub ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the fancy new inference-based completion infrastructure to complete
expressions like
ls $(DEPOT_PATH[1])/<tab>in the REPL shell. Currentlydoesn't extend to path completions for cmd and string literals in the
normal REPL mode, but that shouldn't be too hard to add.
Still needs tests