remove unnecessary \up (upright) from some latex abbrevs (e.g. \upMu -> \Mu)
#50925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Aug 15, 2023
Member
Author
|
CI failures look unrelated. |
stevengj
force-pushed
the
stevengj-patch-3
branch
from
1a113d5 to
7d6b73e
Compare
Member
Author
|
Rebased; should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50911. Closes #50913.
There were a few oddball symbols prefixed with
\up(for "upright") for no reason that I can tell, ala the LaTeX "upgreek" package, even though we don't use an\upprefix for other upright Greek letters (e.g. we have\alpha, not\upalpha, even though it isn't italicized — we have\italphafor italic alpha).Not breaking since this is just a UI thing.
(In practice, I doubt many people use these symbols. e.g.
\upMuisΜ, which looks a lot like the LatinM. But there is no reason to have the\upprefix here. It seems to have just been an automated abbreviation-import snafu. And\upkoppa 'ϟ'(U+O3DF) is visually quite distinctive though I've never seen it used in math, not to mention lowercase — it's definitely goofy to have an\upprefix for it.)