Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typemin, typemax for irrationals #50894

Merged
merged 1 commit into from
Feb 1, 2024
Merged

typemin, typemax for irrationals #50894

merged 1 commit into from
Feb 1, 2024

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Aug 12, 2023

Fixes #36978

@brenhinkeller brenhinkeller added the bugfix This change fixes an existing bug label Aug 12, 2023
@nsajko
Copy link
Contributor Author

nsajko commented Dec 23, 2023

Fixed conflict.

@nsajko
Copy link
Contributor Author

nsajko commented Jan 16, 2024

Bump?

@nsajko
Copy link
Contributor Author

nsajko commented Jan 23, 2024

Fixed another conflict.

@StefanKarpinski
Copy link
Member

LGTM. Can be merged as soon as CI passes again.

@nsajko
Copy link
Contributor Author

nsajko commented Jan 23, 2024

Test failures seem unrelated.

@nsajko
Copy link
Contributor Author

nsajko commented Jan 25, 2024

Can someone merge?

@nsajko
Copy link
Contributor Author

nsajko commented Jan 30, 2024

Test failures are unrelated.

@nsajko
Copy link
Contributor Author

nsajko commented Feb 1, 2024

All checks pass, merge?

@N5N3 N5N3 merged commit 453e9d0 into JuliaLang:master Feb 1, 2024
7 checks passed
@nsajko nsajko deleted the irr branch February 1, 2024 14:38
@devmotion devmotion mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problem with typemin and typemax for Irrational
4 participants
@nsajko @StefanKarpinski @brenhinkeller @N5N3