Mark globals that aren't used in a different partition as internal #50752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
added
compiler:codegen
vtjnash
reviewed
Aug 1, 2023
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
SGTM, though the verifier is not currently happy with this
pchintalapudi
force-pushed
the
pc/internalize
branch
from
def97f6 to
fb0bc12
Compare
Member
Author
|
Since we've resolved this by requiring a single thread for COFF output when there are lots of symbols, I'm closing this as it results in undefined symbols in the generated dynamic library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help with #50729 (comment), if the issue is actually that COFF doesn't like large numbers of external hidden symbols. It helps less as the number of threads increases, but the fallback is to compile with fewer image threads, which will restore a binary that has an extremely limited subset of external symbols.