Skip to content

only time inference if any work is actually done #49817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented May 15, 2023

Otherwise, this can give a huge number of instant events, for example when profiling the creation of corecompiler.ji

@KristofferC KristofferC requested a review from topolarity May 15, 2023 09:34
Copy link
Member

@topolarity topolarity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when I tested I didn't see any major overhead from all of these events during sysimage generation, but it's probably still nice to keep the "useless" events down in volume

@KristofferC
Copy link
Member Author

When enabling stack probing I think they caused a significant overhead. Timing corecompiler.ji there where tens of millions of these generated.

@KristofferC KristofferC merged commit 1f161b4 into master May 15, 2023
@KristofferC KristofferC deleted the kc/inf_timing branch May 15, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants