Skip to content

Fix Vararg methods widening with unused type variable. #48953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Fix Vararg methods widening with unused type variable. #48953

merged 2 commits into from
Mar 8, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Mar 8, 2023

close #48950.

@N5N3 N5N3 added the backport 1.9 Change should be backported to release-1.9 label Mar 8, 2023
@N5N3 N5N3 requested a review from vtjnash March 8, 2023 15:02
vtjnash
vtjnash reviewed Mar 8, 2023
View reviewed changes
@N5N3 @vtjnash
Silence warning in test.
9b78b78 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Mar 8, 2023
@vtjnash vtjnash merged commit 4da0359 into JuliaLang:master Mar 8, 2023
@vtjnash
Copy link
Member

vtjnash commented Mar 8, 2023

(cleaned up commit message somewhat when squashing)

@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Mar 9, 2023
KristofferC pushed a commit that referenced this pull request Mar 24, 2023
@N5N3
Fix Vararg methods widening with unused type variable (#48953)
e628534 
Avoid possible nested `Vararg`.

Fix #48950

(cherry picked from commit 4da0359)
@KristofferC KristofferC mentioned this pull request Mar 24, 2023
Merged
52 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
@N5N3 N5N3 deleted the fix-NVA branch April 3, 2023 10:39
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@N5N3 @Xnartharax
Fix Vararg methods widening with unused type variable (JuliaLang#48953
1530f02 
)

Avoid possible nested `Vararg`.

Fix JuliaLang#48950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected TypeError: in Vararg, in type, expected Type, got Vararg{Union{Float64, AbstractArray}} in Julia 1.9
4 participants
@N5N3 @vtjnash @giordano @KristofferC