-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Remove the rem_float intrinsics #48685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nanosoldier |
The win64 test had some failures and then eventually timed out - but the failure is not being detected right in the CI. |
Hmmm. In this case, it seems like the timeout worked correctly, right? The win64 tests timed out at 3 hours, so Buildkite killed the job and exited with status code 1. Then Gabriel retried the failed job; the retry succeeded. |
However, on Viral's other PR, Windows timed out, and Buildkite exited with status code zero, which is obviously a big problem. @staticfloat has sent a support ticket into Buildkite; we're waiting to hear back. |
Oh I didn't realize that. I see the successful job next. |
Your package evaluation job has completed - possible new issues were detected. |
It seems the only package that used the intrinsic is Unitful. They seem to use the intrinsics directly which seems a bit odd. |
I suppose that since the Unitful.jl PR is merged, this PR should be good to merge. |
Since #47501 we have native versions of the rem functions, but the original PR didn't change the fastmath version. It turns out that OpenLibm's fastmath version was already slower than the non fast one, so add a fast version of it and remove the intrinsics.