Subtype: enhance the offset analysis of diagonal vararg length. #48555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
force-pushed
the
offset-var-2nd-trail
branch
7 times, most recently
from
9103ffa to
c8d8214
Compare
Member
Author
|
@nanosoldier |
Collaborator
|
Your package evaluation job has completed - possible new issues were detected. |
N5N3
changed the title
This seems necessary if we want distinguish diagonal `Vararg` length with different offset.
For now just give up offset analysis if we meet a real union.
N5N3
force-pushed
the
offset-var-2nd-trail
branch
from
c8d8214 to
b00548d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the old
offsetfield invarblindingintostenv.I think this is better as it makes offset propagation easier, and we can keep this info in more cases.
Following that, a new
offsetfield has been added back to records the difference between var'slb::TypeVarif it'slb == ub.This seems necessary if we want distinguish diagonal
Vararglength with different offset.This change may not be so urgent, as the concrete path is not affected.
close #39099, close #22123