irinterp: Allow for non-Const first argument

[Keno]

The first argument isn't special here in any way. The original code here just wanted to avoid calling is_all_const_arg with the first argument included, because that condition was already computed when determining f. This code pre-dated semi-concrete eval and is now in the wrong place.

[aviatesk]

For more context, this f !== nothing is there to avoid doing concrete-eval on overlay method call (see

julia/base/compiler/abstractinterpretation.jl

Lines 97 to 102 in 15b7c6b

	if !matches.nonoverlayed
	# currently we don't have a good way to execute the overlayed method definition,
	# so we should give up pure/concrete eval when any of the matched methods is overlayed
	f = nothing
	all_effects = Effects(all_effects; nonoverlayed=false)
	end

), but we don't need this condition to hold for semi-concrete interpretation.

[Keno]

That's not really a good way to signal that information. Why not override the bit in the effects and check that in the eligibility function. f is also nothing if the first argument wasn't Const.

[aviatesk]

Why not override the bit in the effects and check that in the eligibility function.

The nonoverlayed bit indicates if the method in question may involve any overlayed method call, and doesn't say if the method itself is overlayed or not. So an overlayed method may have :foldable & !:nonoverlayed effects.

[aviatesk]

Separated the changes on the inlining algorithm to #48349.

[aviatesk]

Okay, so the changes on opaque closure inlining is necessary for CI to pass on this branch. Apologize for making a noise.