Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backports-release-1.9] add pkgimages to NEWS #48286

Conversation

IanButterworth
Copy link
Member

Once merged here it needs adding to HISTORY on master

@IanButterworth IanButterworth changed the title add pkgimages to NEWS [backports-release-1.9] add pkgimages to NEWS Jan 15, 2023
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

NEWS.md Outdated
@@ -25,6 +25,9 @@ Language changes
Compiler/Runtime improvements
-----------------------------

* The package precompilation process now saves native code into a "pkgimage", meaning that code generated during the
precompilation process will not require compilation after package load, resulting in much faster time to first
execution (TTFX), often referred to as time to first plot ([#44527]) ([#47184]).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to start with the consequence, and then describe how it was done? I.e., "Time to first execution (TTFX, sometimes called time to first plot) is greatly reduced. Package precompilation ..."

@giordano
Copy link
Contributor

giordano commented Jan 15, 2023

Mention also the --pkgimages flag? Also, I presume this should also go into the HISTORY.md file on master, otherwise there will be a mismatch.

NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Jan 16, 2023
@IanButterworth IanButterworth merged commit f5fbc2d into JuliaLang:backports-release-1.9 Jan 16, 2023
@JeffBezanson
Copy link
Member

doc/NEWS-update.jl needs to be run.

@IanButterworth IanButterworth deleted the ib/pkgimages_news branch January 23, 2023 04:08
@IanButterworth
Copy link
Member Author

Thanks. Now run on #48311

@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants