Hook up effect modeling for TypeVar and UnionAll
#48063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had effect modeling for `_typevar`, which `TypeVar` should just defer to. Add a simple model for `UnionAll` as well, though in the future we can add the Vararg case also.
aviatesk
approved these changes
Jan 1, 2023
| if isa(a3, Const) | ||
| body = a3.val | ||
| elseif isType(a3) | ||
| body = a3.parameters[1] | ||
| canconst = false | ||
| else | ||
| return Any | ||
| return CallMeta(Any, Effects(EFFECTS_TOTAL; nothrow), NoCallInfo()) |
There was a problem hiding this comment.
Suggested change
| return CallMeta(Any, Effects(EFFECTS_TOTAL; nothrow), NoCallInfo()) | |
| return CallMeta(Any, EFFECTS_THROWS, NoCallInfo()) |
There was a problem hiding this comment.
This one I think in theory could be proven nothrow, even if we don't model the rt.
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had effect modeling for
_typevar, whichTypeVarshould just defer to. Add a simple model forUnionAllas well, though in the future we can add the Vararg case also.