Fix unaliascopy(::SubArray) with indices of Array{<:CartesianIndex}
#47779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
commented
Dec 11, 2023
vtjnash
approved these changes
Dec 11, 2023
N5N3
force-pushed
the
fix-unaliascopy
branch
from
e142dbf to
a939998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug caused by the trimming trick.
Base.index_lengthsis not a proper tool to calculate the trimmed shape asindicesmight consume more than 1 dim.And we can avoid the unneeded "
repeat" when we meetArray{CartesianIndex{0}}Test added.
Close #47644.