[Filesystem]: rm(; recursive=true) should ignore UV_EACCES
#47668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Nov 22, 2022
maleadt
approved these changes
Nov 22, 2022
The command-line program `rm` has no problem deleting an empty directory
that we do not have listing permissions on, so we should follow suit.
Example:
```
mktempdir() do dir
mkpath("$(dir)/foo")
chmod("$(dir)/foo", 0o200)
rm(dir; recursive=true)
end
```
maleadt
force-pushed
the
sf/fix_rm_permissions
branch
from
18e4e13
to
b630c20
Compare
|
win32 and ppc failures unrelated, and also happen on master. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
The command-line program `rm` has no problem deleting an empty directory
that we do not have listing permissions on, so we should follow suit.
Example:
```
mktempdir() do dir
mkpath("$(dir)/foo")
chmod("$(dir)/foo", 0o200)
rm(dir; recursive=true)
end
```
(cherry picked from commit d0a211a)
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
The command-line program `rm` has no problem deleting an empty directory
that we do not have listing permissions on, so we should follow suit.
Example:
```
mktempdir() do dir
mkpath("$(dir)/foo")
chmod("$(dir)/foo", 0o200)
rm(dir; recursive=true)
end
```
(cherry picked from commit d0a211a)
51 tasks
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
The command-line program `rm` has no problem deleting an empty directory
that we do not have listing permissions on, so we should follow suit.
Example:
```
mktempdir() do dir
mkpath("$(dir)/foo")
chmod("$(dir)/foo", 0o200)
rm(dir; recursive=true)
end
```
(cherry picked from commit d0a211a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command-line program
rmhas no problem deleting an empty directory that we do not have listing permissions on, so we should follow suit.Example: