Skip to content

Introduces get-lld to fix make full-source-dist USE_BINARYBUILDER=0 #47589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

petvana
Copy link
Member

@petvana petvana commented Nov 16, 2022

This aims to fix #47584. There are no extra sources for lld because it's compiled as part of llvm. In the original PR, I've tested only make USE_BINARYBUILDER=0.

@petvana petvana added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug labels Nov 16, 2022
@petvana petvana marked this pull request as ready for review November 16, 2022 09:33
@ararslan ararslan added the backport 1.9 Change should be backported to release-1.9 label Nov 16, 2022
@DilumAluthge
Copy link
Member

@ararslan Can you test out this branch?

@ararslan
Copy link
Member

Seems not to work:

make[5]: Entering directory '/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release'
[ 82%] Linking CXX shared library ../../lib/libLLVM-14jl.so
make[5]: Leaving directory '/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release'
/usr/bin/ld:/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release/./lib/tools/llvm-shlib/simple_version_script.map:0: syntax error in VERSION script
collect2: error: ld returned 1 exit status
tools/llvm-shlib/CMakeFiles/LLVM.dir/build.make:238: recipe for target 'lib/libLLVM-14jl.so' failed
make[5]: *** [lib/libLLVM-14jl.so] Error 1
make[5]: Leaving directory '/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release'
CMakeFiles/Makefile2:25594: recipe for target 'tools/llvm-shlib/CMakeFiles/LLVM.dir/all' failed
make[4]: *** [tools/llvm-shlib/CMakeFiles/LLVM.dir/all] Error 2
make[4]: *** Waiting for unfinished jobs....
[ 82%] Built target LLVMExegesisX86
make[4]: Leaving directory '/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release'
Makefile:155: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/data/ararslan/julia/deps/scratch/llvm-julia-14.0.6-0/build_Release'
/data/ararslan/julia/deps/llvm.mk:250: recipe for target 'scratch/llvm-julia-14.0.6-0/build_Release/build-compiled' failed
make[2]: *** [scratch/llvm-julia-14.0.6-0/build_Release/build-compiled] Error 2
make[2]: Leaving directory '/data/ararslan/julia/deps'
Makefile:62: recipe for target 'julia-deps' failed
make[1]: *** [julia-deps] Error 2
make[1]: Leaving directory '/data/ararslan/julia'
Makefile:49: recipe for target '/data/ararslan/julia/doc/_build/html/en/index.html' failed
make: *** [/data/ararslan/julia/doc/_build/html/en/index.html] Error 2

@petvana
Copy link
Member Author

petvana commented Nov 18, 2022

Seems not to work:

Weird. It was successful locally on Ubuntu 20.04. Moreover, I'm not even sure it's related to lld ...

@gbaraldi
Copy link
Member

I've had issues with our from source LLVM build in one computer so we might want to find out what is going on there

@petvana
Copy link
Member Author

petvana commented Nov 21, 2022

Can we merge this PR? It solves at least the missing get-lld target.

@vtjnash vtjnash merged commit 3200219 into JuliaLang:master Nov 23, 2022
KristofferC pushed a commit that referenced this pull request Nov 28, 2022
Fixes `make -C deps getall`

(cherry picked from commit 3200219)
@KristofferC KristofferC mentioned this pull request Dec 14, 2022
26 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make full-source-dist USE_BINARYBUILDER=0 is broken due to LLD
6 participants