-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Introduces get-lld to fix make full-source-dist USE_BINARYBUILDER=0
#47589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
@ararslan Can you test out this branch? |
daba2cb
to
a7cfb83
Compare
a7cfb83
to
8fe5832
Compare
Seems not to work:
|
Weird. It was successful locally on Ubuntu 20.04. Moreover, I'm not even sure it's related to |
I've had issues with our from source LLVM build in one computer so we might want to find out what is going on there |
Can we merge this PR? It solves at least the missing |
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2022
Fixes `make -C deps getall` (cherry picked from commit 3200219)
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #47584. There are no extra sources for
lld
because it's compiled as part of llvm. In the original PR, I've tested onlymake USE_BINARYBUILDER=0
.