-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed attributes from arguments to gc_preserve_begin #47482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM adds the nonnull attribute on its own, which makes the verifier fail. Fixes JuliaLang#47245
vtjnash
added
backport 1.6
Change should be backported to release-1.6
backport 1.8
Change should be backported to release-1.8
merge me
PR is reviewed. Merge when all tests are passing
compiler:llvm
For issues that relate to LLVM
labels
Nov 7, 2022
n.b. Curiously it is the InstCombine pass that does this transform to our argument list attributes |
KristofferC
pushed a commit
that referenced
this pull request
Nov 8, 2022
26 tasks
DilumAluthge
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Nov 9, 2022
DilumAluthge
pushed a commit
that referenced
this pull request
Nov 15, 2022
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6
Change should be backported to release-1.6
compiler:llvm
For issues that relate to LLVM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM adds the nonnull attribute on its own, which makes the verifier fail.
Fixes #47245