Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed attributes from arguments to gc_preserve_begin #47482

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Removed attributes from arguments to gc_preserve_begin #47482

merged 1 commit into from
Nov 8, 2022

Conversation

apaz-cli
Copy link
Member

@apaz-cli apaz-cli commented Nov 7, 2022

LLVM adds the nonnull attribute on its own, which makes the verifier fail.

Fixes #47245

@apaz-cli
Removed attributes from arguments to gc_preserve_begin
52a6ed4 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes JuliaLang#47245
@vtjnash vtjnash added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 merge me PR is reviewed. Merge when all tests are passing compiler:llvm For issues that relate to LLVM labels Nov 7, 2022
@vtjnash
Copy link
Member

vtjnash commented Nov 7, 2022

n.b. Curiously it is the InstCombine pass that does this transform to our argument list attributes
https://github.com/llvm/llvm-project/blob/432a7e284440c719637fe34b972c96c9af0e01f1/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp#L3070-L3093 from https://reviews.llvm.org/D9132

@vtjnash vtjnash merged commit bc39fd1 into JuliaLang:master Nov 8, 2022
KristofferC pushed a commit that referenced this pull request Nov 8, 2022
@apaz-cli @KristofferC
Removed attributes from arguments to gc_preserve_begin (#47482)
9861bf1 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
@KristofferC KristofferC mentioned this pull request Nov 8, 2022
Merged
26 tasks
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 9, 2022
DilumAluthge pushed a commit that referenced this pull request Nov 15, 2022
@apaz-cli @DilumAluthge
Removed attributes from arguments to gc_preserve_begin (#47482)
b66e38c 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Dec 16, 2022
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Closed
78 tasks
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@apaz-cli
Removed attributes from arguments to gc_preserve_begin (#47482)
eb5dc3f 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@apaz-cli
Removed attributes from arguments to gc_preserve_begin (#47482)
e0b8288 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@apaz-cli
Removed attributes from arguments to gc_preserve_begin (#47482)
b1bd4af 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@apaz-cli @staticfloat
Removed attributes from arguments to gc_preserve_begin (#47482)
08bd966 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@apaz-cli @KristofferC
Removed attributes from arguments to gc_preserve_begin (#47482)
97ea252 
LLVM adds the nonnull attribute on its own, which makes
the verifier fail.

Fixes #47245

(cherry picked from commit bc39fd1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 compiler:llvm For issues that relate to LLVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing BSplineKit asserts in LLVM with Attribute after last parameter!
4 participants
@apaz-cli @vtjnash @KristofferC @DilumAluthge