Skip to content

map of unequal length bitarray #47013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 13, 2022
Merged

map of unequal length bitarray #47013

merged 24 commits into from
Oct 13, 2022

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Oct 2, 2022

fix #47011

  • fix bit_map!
  • add bit array test for unequal length

@CameronBieganek
Copy link
Contributor

That was fast. 🙂

N5N3
N5N3 reviewed Oct 3, 2022
View reviewed changes
Moelf and others added 2 commits October 3, 2022 00:53
@Moelf @N5N3
Update base/bitarray.jl
b32fd47 
Co-authored-by: N5N3 <2642243996@qq.com>
@Moelf
correction and more tests
2eab022
@Moelf Moelf requested a review from N5N3 October 3, 2022 13:22
N5N3
N5N3 reviewed Oct 4, 2022
View reviewed changes
@N5N3 N5N3 added the arrays [a, r, r, a, y, s] label Oct 4, 2022
Moelf and others added 4 commits October 3, 2022 23:07
@Moelf @N5N3
Update base/bitarray.jl
a8c8044 
Co-authored-by: N5N3 <2642243996@qq.com>
@Moelf @N5N3
Update base/bitarray.jl
8439e50 
Co-authored-by: N5N3 <2642243996@qq.com>
@Moelf
relax three arg bit_map!
93d10ca
@Moelf
more tests
f4de9da
CameronBieganek
CameronBieganek reviewed Oct 4, 2022
View reviewed changes
CameronBieganek
CameronBieganek reviewed Oct 4, 2022
View reviewed changes
CameronBieganek
CameronBieganek reviewed Oct 4, 2022
View reviewed changes
Moelf and others added 2 commits October 4, 2022 11:24
@Moelf @CameronBieganek
Update test/bitarray.jl
9bb987d 
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
@Moelf
more tests and diagram
03d5510
CameronBieganek
CameronBieganek reviewed Oct 4, 2022
View reviewed changes
CameronBieganek
CameronBieganek reviewed Oct 4, 2022
View reviewed changes
Moelf and others added 3 commits October 4, 2022 13:37
@Moelf @CameronBieganek
Update base/bitarray.jl
2fee4c4 
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
@Moelf @CameronBieganek
Update base/bitarray.jl
96205c9 
Co-authored-by: Cameron Bieganek <8310743+CameronBieganek@users.noreply.github.com>
@Moelf
fix typo
be34441
@N5N3 N5N3 merged commit 01310a9 into JuliaLang:master Oct 13, 2022
@Moelf Moelf deleted the map_of_unequal_length_bitarray branch October 13, 2022 13:49
This was referenced Aug 3, 2023
Closed
Merged
oscardssmith added a commit that referenced this pull request Aug 5, 2023
@oscardssmith
fix bit_map! with aliasing (#50781)
3e04129 
fixes #50780 caused by #47013.
KristofferC pushed a commit that referenced this pull request Aug 10, 2023
@oscardssmith @KristofferC
fix bit_map! with aliasing (#50781)
e57f1c7 
fixes #50780 caused by #47013.

(cherry picked from commit 3e04129)
KristofferC pushed a commit that referenced this pull request Aug 10, 2023
@oscardssmith @KristofferC
fix bit_map! with aliasing (#50781)
593dcde 
fixes #50780 caused by #47013.

(cherry picked from commit 3e04129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N5N3 N5N3 N5N3 approved these changes

+1 more reviewer

@CameronBieganek CameronBieganek CameronBieganek left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map! errors on a BitVector when the destination is longer than the source
3 participants
@Moelf @CameronBieganek @N5N3