Skip to content

Conversation

@N5N3
Copy link
Member

@N5N3 N5N3 commented Sep 30, 2022

It looks harmless to add them to test as we have fixed two of them by accident.
close #38497
close #33138

@N5N3 N5N3 added the test This change adds or pertains to unit tests label Sep 30, 2022
@N5N3 N5N3 changed the title Add some know subtype issue to test file. Add some known subtype issue to the test file. Sep 30, 2022
@vtjnash
Copy link
Member

vtjnash commented Sep 30, 2022

LGTM

@N5N3 N5N3 merged commit 95a5ad8 into JuliaLang:master Oct 2, 2022
@N5N3 N5N3 deleted the subtype_test branch October 2, 2022 02:36
@ulysses4ever
Copy link
Contributor

ulysses4ever commented Oct 3, 2022

Why does it say “close #33138” but only adds a test for #33137? From my experiments, both of those are fixed now (miraculously), so, from here:

@ulysses4ever
Copy link
Contributor

(Of course, I messed up the numbers too, fixed now)

@DilumAluthge
Copy link
Member

Is there any chance that this would cause CI to hang when running with assertions? E.g. https://buildkite.com/julialang/julia-buildkite-scheduled/builds/325#01839d90-e44a-43a6-bb7d-ed31dcb2bd39

(rr trace is available)

@N5N3
Copy link
Member Author

N5N3 commented Oct 3, 2022

@DilumAluthge Some of the added tests throw stack overflow on master. So it might be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This change adds or pertains to unit tests

Projects

None yet

4 participants