Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CallInfo propagate effects #46962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aviatesk
Copy link
Member

Add call_effects(::CallInfo) -> Effects feature to the CallInfo interface. This change will make it easier for the inlining algorithm to see the effects of a call in question.

This commit also setups new ModifyFieldInfo callinfo type so that it can propagate modifyfield!-specific information to the inliner, which implements a special handling for the call.

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@aviatesk
Copy link
Member Author

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@fingolfin
Copy link
Contributor

(Super nerdy nitpick, please feel free to ignore and don't kill me about it; but this is a pet peeve of mine..: "setup" is a noun; the corresponding verb is "set up". So "e.g. "This commit sets up ..." instead of "This commit setups" ; but "This is an elaborate setup"... ;-)

@aviatesk aviatesk force-pushed the avi/callinfo branch 4 times, most recently from e15304a to 1111aac Compare October 5, 2022 03:27
Base automatically changed from avi/callinfo to master October 7, 2022 00:44
@aviatesk aviatesk reopened this Oct 7, 2022
@brenhinkeller brenhinkeller added the compiler:effects effect analysis label Nov 17, 2022
@aviatesk aviatesk force-pushed the avi/callinfo-effects branch 2 times, most recently from a531f9c to 59e5dc8 Compare December 1, 2022 03:26
@aviatesk aviatesk changed the base branch from master to avi/follow-47371 December 1, 2022 03:31
@aviatesk
Copy link
Member Author

aviatesk commented Dec 1, 2022

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Base automatically changed from avi/follow-47371 to master December 1, 2022 09:48
@aviatesk aviatesk force-pushed the avi/callinfo-effects branch 2 times, most recently from 9b31f82 to 06da627 Compare December 6, 2022 04:50
@aviatesk
Copy link
Member Author

aviatesk commented Dec 6, 2022

@nanosoldier runbenchmarks("inference", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

Add `call_effects(::CallInfo) -> Effects` feature to the `CallInfo`
interface. This change will make it easier for the inlining algorithm to
see the effects of a call in question.

This commit also setups new `ModifyFieldInfo` callinfo type so that it
can propagate `modifyfield!`-specific information to the inliner, which
implements a special handling for the call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:effects effect analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants