Don't crash on variable sized GC allocations #46914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Sep 26, 2022
vchuravy
added
backport 1.6
Can you open a PR for that aswell? |
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2022
(cherry picked from commit 8003563)
37 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 28, 2022
(cherry picked from commit 8003563)
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 8003563)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 8003563)
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
(cherry picked from commit 8003563)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 8003563)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
(cherry picked from commit 8003563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vchuravy
Can we get this backported to as many Julia versions as feasible. We can also extend a non-backport version to actually handle these cases rather than simply avoid the llvm assertion as above.