Fixup for #46508 #46877
Merged
Fixup for #46508 #46877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed this fixes the problem! Thanks for the quick fixup. Is it possible to add a test? (I don't know how easy it is to cook up a small example exhibiting this bug.) |
|
I don't know how I would go about testing this. |
|
Then I guess this is good to go :) |
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2022
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
that referenced
this pull request
Oct 2, 2022
KristofferC
pushed a commit
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46508 is based on the (false) assumption that
defsis always presorted. I hope this PR makes that assumption true.@thofma, does this fix the error when testing Hecke?