Fix type inference error reported in #43064. #46302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
added
types and dispatch
N5N3
force-pushed
the
subtype_fix
branch
2 times, most recently
from
a6d766e to
3c30f72
Compare
vtjnash
reviewed
Aug 10, 2022
vtjnash
reviewed
Aug 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
`R` is always false here.
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the subtype bug reported in #43064.
Before this PR,
exists_subtypewould erase the under-processing value inenvoutifsubtypereturnfalse, but we should actually keep it as the nextsubtype_unionallneeds it to check whether we have assigned a (different) environment value. 7c76a97 skips the erasing if there are remaing Runions to test.(#41096 is still broken, as the root cause looks different)