remove dead comment #46132
Merged
remove dead comment #46132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
approved these changes
Jul 21, 2022
Keno
reviewed
Jul 22, 2022
#45993 fixed this bug.
aviatesk
force-pushed
the
avi/deadcomment
branch
from
3463c0e
to
e91a246
Compare
Keno
approved these changes
Jul 22, 2022
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
JuliaLang#45993 fixed this bug, let's make the math effect-tests actually fail
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
JuliaLang#45993 fixed this bug, let's make the math effect-tests actually fail
|
Should this be backported to 1.8.3? I was looking at CI, and seemingly this would have disabled "bad effects" I see? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45993 fixed this bug.