Close race condition in Filewatching tests #46028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #45982? |
vtjnash
approved these changes
Jul 13, 2022
DilumAluthge
added
the
system:apple silicon
|
Should these changes also be upstreamed to the Pidfile.jl package? |
On some machines, we are able to delay starting our loop until more than a second after we take the lock, which of course breaks the test. Let's use a synchronization barrier to ensure that we're testing what we intend to.
staticfloat
force-pushed
the
sf/filewatching_test_fix
branch
from
d81be11 to
3e18669
Compare
|
Waiting for |
Bump |
|
Yep, sorry about that |
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
On some machines, we are able to delay starting our loop until more than a second after we take the lock, which of course breaks the test. Let's use a synchronization barrier to ensure that we're testing what we intend to.
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
On some machines, we are able to delay starting our loop until more than a second after we take the lock, which of course breaks the test. Let's use a synchronization barrier to ensure that we're testing what we intend to.
Keno
added a commit
that referenced
this pull request
Aug 28, 2022
I think the synchronization in #46028 was incomplete to actually fix the issue. Try to fix it by accounting the time taken to wait for the synchronization event into the lock time. Otherwise, the test pass/fail depends on the scheduler ordering.
Keno
added a commit
that referenced
this pull request
Aug 28, 2022
I think the synchronization in #46028 was incomplete to actually fix the issue. Try to fix it by accounting the time taken to wait for the synchronization event into the lock time. Otherwise, the test pass/fail depends on the scheduler ordering.
Keno
added a commit
that referenced
this pull request
Aug 29, 2022
I think the synchronization in #46028 was incomplete to actually fix the issue. Try to fix it by accounting the time taken to wait for the synchronization event into the lock time. Otherwise, the test pass/fail depends on the scheduler ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some machines, we are able to delay starting our loop until more than
a second after we take the lock, which of course breaks the test. Let's
use a synchronization barrier to ensure that we're testing what we
intend to.