-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[win] Fix source build without pre-built deps #45712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
bfa554c
abf01e9
b9e6b99
304186c
57a14af
34d2cec
72f1801
56e15e6
12c7310
80a287d
2c0843e
07c1686
9f5f0df
4dfeda3
a80d31e
bd47760
46c5844
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,12 @@ ifneq ($(USE_BINARYBUILDER_P7ZIP),1) | |
$(SRCCACHE)/p7zip-$(P7ZIP_VER).tar.gz: | $(SRCCACHE) | ||
$(JLDOWNLOAD) $@ https://github.com/jinfeihan57/p7zip/archive/refs/tags/v$(P7ZIP_VER).tar.gz | ||
|
||
P7ZIP_BUILD_OPTS := $(MAKE_COMMON) | ||
# Build with cygwin, not use cross build. | ||
ifeq (,$(findstring CYGWIN,$(BUILD_OS))) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems unlikely this should care about the BUILD_OS There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it's a workaround for cygwin.
In my case, on Windows, build p7zip with |
||
P7ZIP_BUILD_OPTS += CC="$(CC)" CXX="$(CXX)" | ||
endif | ||
|
||
$(BUILDDIR)/p7zip-$(P7ZIP_VER)/source-extracted: $(SRCCACHE)/p7zip-$(P7ZIP_VER).tar.gz | ||
$(JLCHECKSUM) $< | ||
mkdir -p $(dir $@) | ||
|
@@ -17,7 +23,7 @@ checksum-p7zip: $(SRCCACHE)/p7zip-$(P7ZIP_VER).tar.gz | |
|
||
$(BUILDDIR)/p7zip-$(P7ZIP_VER)/build-configured: $(BUILDDIR)/p7zip-$(P7ZIP_VER)/source-extracted | ||
$(BUILDDIR)/p7zip-$(P7ZIP_VER)/build-compiled: $(BUILDDIR)/p7zip-$(P7ZIP_VER)/build-configured | ||
$(MAKE) -C $(dir $<) $(MAKE_COMMON) CC="$(CC)" CXX="$(CXX)" 7za | ||
$(MAKE) -C $(dir $<) $(P7ZIP_BUILD_OPTS) 7za | ||
echo 1 > $@ | ||
|
||
define P7ZIP_INSTALL | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
From 3732420725efbf410df5863b91a09ca214ee18ba Mon Sep 17 00:00:00 2001 | ||
From: "Y. Yang" <metab0t@users.noreply.github.com> | ||
Date: Thu, 16 Jun 2022 19:16:37 +0800 | ||
Subject: [PATCH] Fix DLL import library name | ||
|
||
https://aur.archlinux.org/packages/mingw-w64-libssh2 | ||
https://cmake.org/cmake/help/latest/prop_tgt/IMPORT_PREFIX.html | ||
--- | ||
src/CMakeLists.txt | 1 + | ||
1 file changed, 1 insertion(+) | ||
|
||
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt | ||
index cb8fee1..17ecefd 100644 | ||
--- a/src/CMakeLists.txt | ||
+++ b/src/CMakeLists.txt | ||
@@ -220,6 +220,7 @@ endif() | ||
add_library(libssh2 ${SOURCES}) | ||
# we want it to be called libssh2 on all platforms | ||
set_target_properties(libssh2 PROPERTIES PREFIX "") | ||
+set_target_properties(libssh2 PROPERTIES IMPORT_PREFIX "") | ||
|
||
target_compile_definitions(libssh2 PRIVATE ${PRIVATE_COMPILE_DEFINITIONS}) | ||
target_include_directories(libssh2 | ||
-- | ||
2.36.1 | ||
|
Uh oh!
There was an error while loading. Please reload this page.