Refactor the meaning of NewSSAValue in IncrementalCompact #45610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curently, uncompacted nodes in IncrementalCompact can refer to old SSAValues (as regular SSAValues) and new-new SSAValues (as NewSSAValues), but not post-compaction SSA values. This is a bit of an odd missing middle and is useful when re-ordering instructions from beyond the current insertion point. This PR updates the definition of NewSSAValue to be able to refer to both post-compaction SSAValues (using positive `id` values) and new-new SSAValues (using negative `id` values), which also makes their meaning independent of context (like OldSSAValue). While we're at it, also clean up the `getindex` methods for IncrementalCompact to return `Instruction` (as we did for IRCode).
|
seems like an odd flake? |
|
Seems probably not new #45195 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curently, uncompacted nodes in IncrementalCompact can refer
to old SSAValues (as regular SSAValues) and new-new SSAValues
(as NewSSAValues), but not post-compaction SSA values. This
is a bit of an odd missing middle and is useful when re-ordering
instructions from beyond the current insertion point. This PR
updates the definition of NewSSAValue to be able to refer
to both post-compaction SSAValues (using positive
idvalues)and new-new SSAValues (using negative
idvalues), which alsomakes their meaning independent of context (like OldSSAValue).
While we're at it, also clean up the
getindexmethods forIncrementalCompact to return
Instruction(as we did for IRCode).