Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete size checks in BLAS.[sy/he]mm! #45605

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Complete size checks in BLAS.[sy/he]mm! #45605

merged 3 commits into from
Jul 7, 2022

Conversation

dkarrasch
Copy link
Member

Fixes #45572. This should be backported to v1.6.x, but I'm not sure if that has the lazy string generation.

@dkarrasch dkarrasch added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 bugfix This change fixes an existing bug linear algebra Linear algebra labels Jun 7, 2022
@jishnub
Copy link
Contributor

jishnub commented Jun 7, 2022

Do the string operations add significant overhead if they aren't lazy? Otherwise, would be good to have this backported to v1.6

@dkarrasch
Copy link
Member Author

I just applied "pattern matching", but I could try to branch off from release-v1.6 and make another PR there if that helps backporting.

@dkarrasch
Copy link
Member Author

dkarrasch commented Jun 8, 2022

This still needs adjustments of the error messages and tests for the case side = 'R', but I'll do that a little later.

@dkarrasch dkarrasch added the needs tests Unit tests are required for this change label Jun 8, 2022
@dkarrasch dkarrasch removed the needs tests Unit tests are required for this change label Jun 9, 2022
@KristofferC
Copy link
Member

Is this ready to go @dkarrasch?

@dkarrasch
Copy link
Member Author

Is this ready to go @dkarrasch?

Yes, the only remaining question is how to help with the backport, since v1.6 doesn't have lazy strings.

@dkarrasch dkarrasch merged commit da13d78 into master Jul 7, 2022
@dkarrasch dkarrasch deleted the dk/symmfix branch July 7, 2022 08:37
KristofferC pushed a commit that referenced this pull request Jul 7, 2022
KristofferC pushed a commit that referenced this pull request Jul 8, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 8, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mul! with Symmetric does not check sizes are compatible
5 participants