Fix bug in pinv
#45009
Merged
Fix bug in pinv
#45009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thchr
reviewed
Apr 17, 2022
stdlib/LinearAlgebra/test/pinv.jl
Outdated
Comment on lines
73
to
77
| for _ in 1:100 | ||
| b = a*randn(n) | ||
| x = apinv*b | ||
| @test norm(a*x-b)/norm(b) ≈ 0 atol=tol1 | ||
| end |
There was a problem hiding this comment.
Why the loop here? Is this intended or something left over from editing? Same below in lines 83-87.
There was a problem hiding this comment.
Since randn(n) is included, I thought it would be better to verify multiple times rather than just one test.
There was a problem hiding this comment.
I think just one test should suffice. If we do this everywhere, the tests will take way too long.
There was a problem hiding this comment.
Okay, I have removed for _ in 1:100.
|
I hope this PR will be backported to 1.6 and 1.7. |
ViralBShah
added
backport 1.6
|
Added the backport labels. Not sure if another 1.7 release will happen before 1.8 comes out. |
stevengj
approved these changes
Apr 26, 2022
45 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 16, 2022
67 tasks
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #44234.