Avoid O(N^2) behavior in widenreturn #44437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In functions with lots of slots that construct PartialStructs with lots of fields, `widenreturn` would attempt to repeatedly find an interesting slot for Interconditional to use. This is unnecessary, because the slot selected does not depend on the value of the PartialStruct field. Memoize this computation and only do it once per return statement.
|
Is there a simple example where this is a performance win? |
|
I've been working through all the pathologies of this testcase: https://gist.github.com/Keno/5587fbfe89bff96c863c8eeb1477defa. This was one of them. |
vtjnash
reviewed
Mar 4, 2022
| for i in 1:length(fields) | ||
| a = fields[i] | ||
| a = isvarargtype(a) ? a : widenreturn(a, bestguess, nslots, slottypes, changes) | ||
| a = isvarargtype(a) ? a : widenreturn(a, bestguess, nslots, slottypes, changes, interconditional_slot) |
There was a problem hiding this comment.
Fields are prohibited from containing Conditional/InterConditional values
There was a problem hiding this comment.
Then the code that is here now is wrong, because it likes to add them.
|
Replaced by #44438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In functions with lots of slots that construct PartialStructs with
lots of fields,
widenreturnwould attempt to repeatedly find aninteresting slot for Interconditional to use. This is unnecessary,
because the slot selected does not depend on the value of the
PartialStruct field. Memoize this computation and only do it once
per return statement.