-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alloc profiler: adjust warnings in docs; remove logged warning from implementation #44077
Conversation
since we think we've gotten all the allocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rad. Thanks Pete. I'll wait for green CI then merge!
error:
Not sure what this has to do with us 🤔 |
Yes agreed, this one seems unrelated (maybe flaky?). |
(Freebsd tests never ran; there must be something wrong with the bulid bot. Going to merge now; this is mostly a docs cleanup.) |
…mplementation (JuliaLang#44077) * docs: update warning in the manual; add to reference * remove missed allocs warning from `fetch` since we think we've gotten all the allocs * remove tests of warning message, since it's no longer there
…mplementation (JuliaLang#44077) * docs: update warning in the manual; add to reference * remove missed allocs warning from `fetch` since we think we've gotten all the allocs * remove tests of warning message, since it's no longer there
…mplementation (JuliaLang#44077) * docs: update warning in the manual; add to reference * remove missed allocs warning from `fetch` since we think we've gotten all the allocs * remove tests of warning message, since it's no longer there
Since we think we're now getting all the allocs:
UnknownType
in allocations results) #43688 has been updated accordingly)Maybe we should still log a warning about missing types?
cc @NHDaly