-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PATH_MAX to JL_PATH_MAX #43986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should prefix this with |
2005m
changed the title
Change PATH_MAX to JULIA_PATH_MAX
Change PATH_MAX to JL_PATH_MAX
Feb 9, 2022
@musm please let me know if you need anything else. |
DilumAluthge
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Feb 14, 2022
The CI failures seem to be related to the contents of this PR. package_win32 (log):
package_win64 (log):
|
@DilumAluthge should be fixed for win_32 and win_64. Please let me know if any issue related to this PR. Thank you. |
DilumAluthge
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Feb 15, 2022
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Merged
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #10682 and to avoid warning like the below one (see https://discourse.julialang.org/t/ccall-c-sort-vector-of-string/74635/21):