Skip to content

Revert "IO: tie lifetime of handle field to container" #43924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

Revert "IO: tie lifetime of handle field to container" #43924

merged 1 commit into from
Jan 25, 2022

Conversation

Keno
Copy link
Member

@Keno Keno commented Jan 25, 2022

Reverts #43218

That PR last ran without full CI, and it appears current CI was broken by it. Revert for now and we can investigate in the morning and fix it.

@Keno
Copy link
Member Author

Keno commented Jan 25, 2022

buildkite looks fixed with this. Merging.

@Keno Keno merged commit a400a24 into master Jan 25, 2022
@Keno Keno deleted the revert-43218-jn/io-handle-life branch January 25, 2022 08:53
vtjnash added a commit that referenced this pull request Jan 26, 2022
@vtjnash
Revert "Revert "IO: tie lifetime of handle field to container (#43216)…
85bd535 
…" (#43924)"

This reverts commit a400a24.
vtjnash added a commit that referenced this pull request Feb 7, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
02a2e26 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@Keno @LilithHafner
Revert "IO: tie lifetime of handle field to container (JuliaLang#43218)…
3e4d1f7 
…" (JuliaLang#43924)

This reverts commit 5cd31b5.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@Keno @LilithHafner
Revert "IO: tie lifetime of handle field to container (JuliaLang#43218)…
08bcfaf 
…" (JuliaLang#43924)

This reverts commit 5cd31b5.
vtjnash added a commit that referenced this pull request Apr 4, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
745d65b 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
vtjnash added a commit that referenced this pull request Apr 6, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
f2644f8 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
vtjnash added a commit that referenced this pull request Apr 6, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
4f5cf90 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
vtjnash added a commit that referenced this pull request Apr 12, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
1b8f074 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
@vtjnash vtjnash mentioned this pull request Apr 12, 2022
Merged
vtjnash added a commit that referenced this pull request Apr 12, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
6573350 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
vtjnash added a commit that referenced this pull request Apr 13, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)"
f3fe012 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
vtjnash added a commit that referenced this pull request Apr 14, 2022
@vtjnash
Reland "IO: tie lifetime of handle field to container (#43218)" (#44883)
72cd1c4 
Reverts a400a24 (#43924).

Fix lifetime issues with the original attempt. We do not need to prevent
it from being GC-finalized: only to make sure it does not conflict with
a concurrent uv_close callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Keno