Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build against LLVM 14 (Git main) #43722

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix build against LLVM 14 (Git main) #43722

merged 1 commit into from
Jan 10, 2022

Conversation

dnadlinger
Copy link
Member

@dnadlinger dnadlinger commented Jan 8, 2022 •
edited
Loading

4c45f29 had reintroduced a use of getNumArgOperands(), which was already slated for removal in (at least) LLVM 12.

@dnadlinger
Fix build against LLVM 14 (Git main)
bb31a3b 
4c45f29 had reintroduced
a use of getNumArgOperands(), which was already slated for
removal in (at least) LLVM 12.
pchintalapudi
pchintalapudi approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@pchintalapudi pchintalapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, I caught the changes to alloc-opt before the PR but missed these new ones.

@vchuravy vchuravy merged commit f7bb391 into JuliaLang:master Jan 10, 2022
@dnadlinger dnadlinger deleted the fix-llvm-14 branch January 10, 2022 00:40
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@dnadlinger @LilithHafner
Fix build against LLVM 14 (Git main) (JuliaLang#43722)
296a6e3 
4c45f29 had reintroduced
a use of getNumArgOperands(), which was already slated for
removal in (at least) LLVM 12.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@dnadlinger @LilithHafner
Fix build against LLVM 14 (Git main) (JuliaLang#43722)
cad547f 
4c45f29 had reintroduced
a use of getNumArgOperands(), which was already slated for
removal in (at least) LLVM 12.
@alexfikl alexfikl mentioned this pull request Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchintalapudi pchintalapudi pchintalapudi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnadlinger @pchintalapudi @vchuravy