Skip to content

Add atan support for missings #43523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViralBShah merged 7 commits into from
Dec 27, 2021
Merged

Add atan support for missings #43523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb48c38
Update math.jl
nicholasbalasus Dec 22, 2021
569944e
Additional Stan support for missings
nicholasbalasus Dec 23, 2021
b5b08aa
added testset for two arg funcs (atan)
nicholasbalasus Dec 24, 2021
ab79f3c
removed extra end in two_argument testset
nicholasbalasus Dec 24, 2021
3c4658c
removed whitespace for bot
nicholasbalasus Dec 24, 2021
c367528
removed additional whitespace for bot
nicholasbalasus Dec 24, 2021
8a38394
removed additional whitespace for bot
nicholasbalasus Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions base/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,6 +1318,9 @@ for f in (:sin, :cos, :tan, :asin, :atan, :acos,
end
@eval $(f)(::Missing) = missing
end
atan(::Missing, ::Missing) = missing
atan(::Number, ::Missing) = missing
atan(::Missing, ::Number) = missing

exp2(x::AbstractFloat) = 2^x
exp10(x::AbstractFloat) = 10^x
Expand Down
13 changes: 13 additions & 0 deletions test/missing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,19 @@ end
end
end

@testset "two-argument functions" begin
two_argument_functions = [atan]

# All two-argument functions return missing when operating on two missing's
# All two-argument functions return missing when operating on a scalar and an missing
# All two-argument functions return missing when operating on an missing and a scalar
for f in two_argument_functions
@test ismissing(f(missing, missing))
@test ismissing(f(1, missing))
@test ismissing(f(missing, 1))
end
end

@testset "bit operators" begin
bit_operators = [&, |, ⊻]

Expand Down