Honor $TEMP and friends when generating anonymous handles
#43515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the beginning path, but that's bad behavior if the user has explicitly requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so. Let's use `uv_os_tmpdir()` to put things in the correct place as much as we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
vtjnash
approved these changes
Dec 22, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…g#43515) On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the beginning path, but that's bad behavior if the user has explicitly requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so. Let's use `uv_os_tmpdir()` to put things in the correct place as much as we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…g#43515) On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the beginning path, but that's bad behavior if the user has explicitly requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so. Let's use `uv_os_tmpdir()` to put things in the correct place as much as we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin, when generating anonymous handles, we hardcoded
/tmpas thebeginning path, but that's bad behavior if the user has explicitly
requested (via setting
$TEMPor$TEMPDIR, etc...) that we not do so.Let's use
uv_os_tmpdir()to put things in the correct place as much aswe can, defaulting to
/tmpif anything goes wrong inside of libuv.