Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor $TEMP and friends when generating anonymous handles #43515

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

staticfloat
Copy link
Member

On Darwin, when generating anonymous handles, we hardcoded /tmp as the
beginning path, but that's bad behavior if the user has explicitly
requested (via setting $TEMP or $TEMPDIR, etc...) that we not do so.
Let's use uv_os_tmpdir() to put things in the correct place as much as
we can, defaulting to /tmp if anything goes wrong inside of libuv.

On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the
beginning path, but that's bad behavior if the user has explicitly
requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so.
Let's use `uv_os_tmpdir()` to put things in the correct place as much as
we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
@staticfloat staticfloat added the system:mac Affects only macOS label Dec 22, 2021
@JeffBezanson JeffBezanson merged commit 0d2160b into master Jan 5, 2022
@JeffBezanson JeffBezanson deleted the sf/better_temp_isolation branch January 5, 2022 18:44
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…g#43515)

On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the
beginning path, but that's bad behavior if the user has explicitly
requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so.
Let's use `uv_os_tmpdir()` to put things in the correct place as much as
we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…g#43515)

On Darwin, when generating anonymous handles, we hardcoded `/tmp` as the
beginning path, but that's bad behavior if the user has explicitly
requested (via setting `$TEMP` or `$TEMPDIR`, etc...) that we not do so.
Let's use `uv_os_tmpdir()` to put things in the correct place as much as
we can, defaulting to `/tmp` if anything goes wrong inside of libuv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants