Skip to content

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 1, 2021

If the object is not a potential Type{...}, we can allow greater
flexibility in recursion. And for Vararg too.

Fixes #42835

If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
@ianatol ianatol added the compiler:inference Type inference label Nov 2, 2021
@ianatol
Copy link
Member

ianatol commented Nov 2, 2021

Seems to also fix #42839

@Sacha0
Copy link
Member

Sacha0 commented Nov 4, 2021

Potentially useful for backport attempts: I attempted to backport this patch to 1.7-RC2 and found that it requires #42583; the latter backports cleanly, and then this patch backports cleanly. Regrettably #42583 introduces unhandled Vararg errors in our test suite, also seen on master.

ianatol pushed a commit to ianatol/julia that referenced this pull request Nov 5, 2021
ianatol pushed a commit to ianatol/julia that referenced this pull request Nov 5, 2021
@KristofferC
Copy link
Member

I've backported this to the backport-release-1.7 branch to run a PkgEval (I am assuming this will be merged here at some point).

@vtjnash vtjnash merged commit 27f579f into master Nov 8, 2021
@vtjnash vtjnash deleted the jn/42835 branch November 8, 2021 19:45
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
If the object is not a potential Type{...}, we can allow greater
flexibility in recursion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.7-rc2] Base.promote_type inference regression
4 participants