Slight improvement to type-stability of StackTraces.lookup
#41847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with SnoopCompile and came across the
StackTraces.lookup
function (that I don't really know what is doing - but it featured non-negligibly in PyCall precompile time).I noticed that there was a slight type-instability in the
line
variable since the if-else statement in one cases branches toline = meth.line
wheremeth::Method
andfieldtype(Method, :line) == Int32
and in the other case branches to0::Int
. This fixes that.