small optimization to subtyping #41672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
performance
JeffBezanson
force-pushed
the
jb/fasterunionstate
branch
from
f0d429f
to
5642eae
Compare
vtjnash
approved these changes
Jul 21, 2021
|
What effect does reducing the size of stack from 100 to 80 have? |
|
It saves some stack space, which seems to help performance a hair. Might as well try to use as little space as we can get away with. |
Zero and copy only the used portion of the union state buffer.
JeffBezanson
force-pushed
the
jb/fasterunionstate
branch
from
5642eae
to
a9ac293
Compare
|
Modified to use even less stack space. |
|
Win32 is still failing CI in subtyping: https://build.julialang.org/#/builders/9/builds/2179 |
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
Zero and copy only the used portion of the union state buffer. (cherry picked from commit 0258553)
63 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Zero and copy only the used portion of the union state buffer.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Zero and copy only the used portion of the union state buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero and copy only the used portion of the union state buffer. Also cut down some integer sizes.
For me this shaves about 0.2 seconds off
using Plotsand the TTFP.