Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small optimization to subtyping #41672

Merged
merged 1 commit into from
Aug 19, 2021
Merged

small optimization to subtyping #41672

merged 1 commit into from
Aug 19, 2021

Conversation

JeffBezanson
Copy link
Member

Zero and copy only the used portion of the union state buffer. Also cut down some integer sizes.

For me this shaves about 0.2 seconds off using Plots and the TTFP.

@JeffBezanson JeffBezanson added performance Must go faster types and dispatch Types, subtyping and method dispatch labels Jul 21, 2021
@oscardssmith
Copy link
Member

What effect does reducing the size of stack from 100 to 80 have?

@JeffBezanson
Copy link
Member Author

It saves some stack space, which seems to help performance a hair. Might as well try to use as little space as we can get away with.

Zero and copy only the used portion of the union state buffer.
@JeffBezanson
Copy link
Member Author

Modified to use even less stack space.

@JeffBezanson JeffBezanson merged commit 0258553 into master Aug 19, 2021
@JeffBezanson JeffBezanson deleted the jb/fasterunionstate branch August 19, 2021 16:41
@vtjnash
Copy link
Member

vtjnash commented Aug 20, 2021

Win32 is still failing CI in subtyping: https://build.julialang.org/#/builders/9/builds/2179

KristofferC pushed a commit that referenced this pull request Aug 25, 2021
Zero and copy only the used portion of the union state buffer.

(cherry picked from commit 0258553)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Zero and copy only the used portion of the union state buffer.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Zero and copy only the used portion of the union state buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants