Skip to content

fix #40773, bug in summarysize on arrays of inlined structs with pointers #41492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix #40773, bug in summarysize on arrays of inlined structs with pointers #41492

merged 1 commit into from
Jul 7, 2021

Conversation

@JeffBezanson
Copy link
Member

fix #40773

@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug backport 1.7 labels Jul 6, 2021
@KristofferC KristofferC mentioned this pull request Jul 7, 2021
Merged
82 tasks
Sacha0
Sacha0 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff! :)

@JeffBezanson JeffBezanson merged commit c49153d into master Jul 7, 2021
@JeffBezanson JeffBezanson deleted the jb/fix40773 branch July 7, 2021 20:54
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@JeffBezanson @KristofferC
fix #40773, bug in summarysize on arrays of inlined structs with po…
cbb3367 
…inters (#41492)

(cherry picked from commit c49153d)
@ghost
Copy link

ghost commented Sep 1, 2021

Can we have this backported to 1.6 as well? I've checked, and it applies cleanly, and it does fix the bug we observed. Are there still going to be 1.6 patch releases?

Thanks in advance.

@oscardssmith oscardssmith added the backport 1.6 Change should be backported to release-1.6 label Sep 1, 2021
@oscardssmith
Copy link
Member

given that 1.6 will be LTS, we should backport.

KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@JeffBezanson @KristofferC
fix #40773, bug in summarysize on arrays of inlined structs with po…
a7081a6 
…inters (#41492)

(cherry picked from commit c49153d)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@JeffBezanson @KristofferC
fix #40773, bug in summarysize on arrays of inlined structs with po…
1dfff1e 
…inters (#41492)

(cherry picked from commit c49153d)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
@NHDaly NHDaly assigned NHDaly and unassigned NHDaly Dec 20, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@JeffBezanson @staticfloat
fix #40773, bug in summarysize on arrays of inlined structs with po…
0dcce94 
…inters (#41492)

(cherry picked from commit c49153d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sacha0 Sacha0 Sacha0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base.summarysize not properly accounting for Vectors containing certain types

6 participants

@JeffBezanson @oscardssmith @Sacha0 @KristofferC @NHDaly