-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Five arg mul! for UniformScaling and improvement in exp! #40731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f1b4e6
to
d3f5944
Compare
dkarrasch
reviewed
May 6, 2021
I think we should additionally test the beta = 0 and the alpha = 0 case, and then this is ready to go. |
When we are still at it, I will add |
dkarrasch
reviewed
May 6, 2021
dkarrasch
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
ed461bb
to
78fb45b
Compare
dkarrasch
reviewed
May 7, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…0731) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
dghosef
pushed a commit
to dghosef/julia
that referenced
this pull request
May 11, 2021
…0731) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
…0731) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…0731) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a five argument
mul!
forUniformScaling
as third argument and second isNumber
(and conversely secondNumber
and thirdUniformScaling
).In particular, it provides the possibility to do in-place add of
UniformScaling
-objects. See the discussion in https://discourse.julialang.org/t/uniform-scaling-inplace-addition-with-matrix/The in-place version of
A += s*I
isAs an example / use-case, I have adapted
exp!
(after #40668) where it was needed four times. Compare: