Fix broadcast error when eltype is inconsistent with getindex #39185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that case we can infer the return type as `Union{}`, which triggers
a type assertion error. This used to work in Julia 1.5.
nalimilan
added
bugfix
|
Wait, so the compiler infers |
|
Oooh, I see. It's because we use (and trust) eltype when guessing the return type, but don't actually do that when evaluating the expression. Further, we don't call |
mbauman
reviewed
Jan 11, 2021
|
Maybe we should just ask inference for the |
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
Indeed. In general, assuming that Though I think it would be safer not to make that change in 1.6, so better backport this one, and only merge #39295 to master? |
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
|
@mbauman @KristofferC Should we merge and backport this? #39295 seems to be harder to implement, and too disruptive for 1.6 anyway. |
|
Yes, this seems reasonable to me — especially as a patch for 1.6's behavior. |
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
* Fix broadcast error when eltype is inconsistent with getindex
In that case we can infer the return type as `Union{}`, which triggers
a type assertion error. This used to work in Julia 1.5.
* whitespace
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
* Update test/broadcast.jl
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit 750f42a)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
* Fix broadcast error when eltype is inconsistent with getindex
In that case we can infer the return type as `Union{}`, which triggers
a type assertion error. This used to work in Julia 1.5.
* whitespace
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
* Update test/broadcast.jl
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit 750f42a)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…ang#39185) * Fix broadcast error when eltype is inconsistent with getindex In that case we can infer the return type as `Union{}`, which triggers a type assertion error. This used to work in Julia 1.5. * whitespace Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> * Update test/broadcast.jl Co-authored-by: Matt Bauman <mbauman@juliacomputing.com> Co-authored-by: Matt Bauman <mbauman@juliacomputing.com> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…ang#39185) * Fix broadcast error when eltype is inconsistent with getindex In that case we can infer the return type as `Union{}`, which triggers a type assertion error. This used to work in Julia 1.5. * whitespace Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com> * Update test/broadcast.jl Co-authored-by: Matt Bauman <mbauman@juliacomputing.com> Co-authored-by: Matt Bauman <mbauman@juliacomputing.com> Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Fix broadcast error when eltype is inconsistent with getindex
In that case we can infer the return type as `Union{}`, which triggers
a type assertion error. This used to work in Julia 1.5.
* whitespace
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
* Update test/broadcast.jl
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Matt Bauman <mbauman@juliacomputing.com>
Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
(cherry picked from commit 750f42a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that case we can infer the return type as
Union{}, which triggers a type assertion error. This used to work in Julia 1.5. (I'm not sure this kind of thing is legitimate but this is probably not the best place to throw an error about it anyway.)Fixes #38422.