Remove try from at-time and close compile timer during throw

[IanButterworth]

#38915 accidentally swallowed assignments due to the try-finally scope

julia> @time x = 1
  0.000001 seconds
1
julia> x
ERROR: UndefVarError: x not defined

this removes the try and disables the timer during every throw

julia> @time x = 1
  0.000000 seconds
1

julia> x
1

And maintains the thread-locality introduced in #38915

julia> x = rand(3,3);

julia> Threads.@threads for i in 1:20 @time x * x; end
  0.652161 seconds (2.36 M allocations: 126.891 MiB, 16.46% gc time, 99.95% compilation time)
  0.655488 seconds (2.36 M allocations: 126.904 MiB, 16.38% gc time, 0.00% compilation time)
  0.652135 seconds (2.36 M allocations: 126.888 MiB, 16.46% gc time, 0.00% compilation time)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.655499 seconds (2.36 M allocations: 126.912 MiB, 16.38% gc time, 0.00% compilation time)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.655506 seconds (2.36 M allocations: 126.919 MiB, 16.37% gc time, 0.00% compilation time)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.653652 seconds (2.36 M allocations: 126.896 MiB, 16.42% gc time, 0.00% compilation time)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000002 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)
  0.000001 seconds (1 allocation: 160 bytes)


julia> @time error(ErrorException("hello"))
ERROR: ErrorException("hello")
Stacktrace:
 [1] error(s::ErrorException)
   @ Base ./error.jl:42
 [2] top-level scope
   @ ./timing.jl:206 [inlined]
 [3] top-level scope
   @ ./REPL[7]:0

cc. @vtjnash @ericphanson

[IanButterworth]

tester_linux64 is now passing again

[KristofferC]

I think you could use something like:

 macro try_finally(ex, fin)
    Expr(:tryfinally,
       :(local val = $(esc(ex))),
       :($(esc(fin)))
       )
end

julia> @try_finally x = 3 println("finalizing")
finalizing
3

julia> x
3

julia> @try_finally error() println("finalizing")
finalizing
ERROR: 
Stacktrace:
 [1] error() at ./error.jl:42
 [2] top-level scope at REPL[4]:1

but this probably works as well.

[IanButterworth]

That's neat.. @JeffBezanson what would be better?

[KristofferC]

I'll merge this to get CI working properly again, and then we can discuss the exact implementation (using Expr(:tryfinally, ...) vs this).

[IanButterworth]

Great, thanks. I'll prepare a PR for the alternative idea