Skip to content

Switch back to LLVM ORC v2, take two #38804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Switch back to LLVM ORC v2, take two #38804

merged 1 commit into from
Dec 17, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Dec 9, 2020

Refs #38008 & #38785

This reverts commit 599d329. Opening as a draft, since still need to investigate and identify the issues it caused.

@vtjnash vtjnash marked this pull request as ready for review December 11, 2020 15:07
@vtjnash vtjnash requested a review from Keno December 11, 2020 15:07
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)
@vtjnash vtjnash merged commit fad55ab into master Dec 17, 2020
@vtjnash vtjnash deleted the jn/orcv2-take2 branch December 17, 2020 21:40
@vchuravy
Copy link
Member

Should we backport this? Maybe for beta2? My reason for it would be to minimize the delta between development and a potential LTS and enable the backporting of bugfixes.

@StefanKarpinski
Copy link
Member

Normally would be against, but it would be really nice if the new LTS uses the new JIT backend.

@musm
Copy link
Contributor

musm commented Dec 19, 2020

Preemptively adding the backport label so we don't forget to make a decision on it.

@musm musm added the backport 1.6 Change should be backported to release-1.6 label Dec 19, 2020
KristofferC pushed a commit that referenced this pull request Dec 19, 2020
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
@KristofferC KristofferC mentioned this pull request Dec 19, 2020
26 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 6, 2021
staticfloat pushed a commit that referenced this pull request Jan 15, 2021
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
Refs JuliaLang#38008 & JuliaLang#38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Refs #38008 & #38785

(This reverts commit 599d329, and fixes
a load ordering issue with our JuliaOJIT::addModule)

(cherry picked from commit fad55ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants