Mention how to get the basetype of an enum #36057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think it would be better to mention |
|
Yes, I didn't like having the internal method there. Just to make sure I understand - instead of having people get the BaseType and cast to it, they should use Integer on the enum value directly. And of course you can then do |
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* Mention how to get the basetype of an enum Fix JuliaLang#28778 * Mention Integer() instead of internal method
jmert
added a commit
to jmert/BitFlags.jl
that referenced
this pull request
Sep 10, 2020
Duplicates improvement made to Base's Enums: JuliaLang/julia#36057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel this is sufficient to address #28778, since it is a non-standard case. The type conversion with Integer() is not specific to enums - and not necessary.