add (un)signed(::Type{Bool}) method #35854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
changed the title
|
Bool is already effectively an unsigned type. Not sure if we should got to 8 bits or straight to U/Int. |
|
Wouldn't it be inconsistent if |
|
Ah, didn't realize that was already defined. They should certainly match. |
JeffBezanson
approved these changes
May 13, 2020
|
Test |
StefanKarpinski
approved these changes
May 13, 2020
|
This looks ready to merge once CI passes. |
Roger-luo
pushed a commit
to Roger-luo/julia
that referenced
this pull request
May 14, 2020
simeonschaub
added a commit
to simeonschaub/julia
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
signed(true)already works and returns anInt, I think this was just an omission.