Skip to content

document some of the thread safety issues with BitArray #33754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2020
Merged

document some of the thread safety issues with BitArray #33754

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c5b236
say that bitarray elements are not thread safe
KristofferC Apr 11, 2020
66b21c9
oops
KristofferC Apr 13, 2020
fca7866
Update bitarray.jl
ViralBShah Apr 30, 2020
f0bbe94
Update bitarray.jl
ViralBShah Apr 30, 2020
39611f8
whitespace fix
ViralBShah Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions base/bitarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ over `Array{Bool, N}` and allowing some operations to work on 64 values at once.
By default, Julia returns `BitArrays` from [broadcasting](@ref Broadcasting) operations
that generate boolean elements (including dotted-comparisons like `.==`) as well as from
the functions [`trues`](@ref) and [`falses`](@ref).

!!! note
Due to its packed storage format, concurrent access to the elements of a `BitArray`
where at least one of them is a write is not thread safe.

"""
mutable struct BitArray{N} <: AbstractArray{Bool, N}
chunks::Vector{UInt64}
Expand Down