fix #33370, avoid collisions between gensyms and anon function names #33426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/fix33370
branch
5 times, most recently
from
34874de to
c9ea2c6
Compare
c42f
approved these changes
Oct 2, 2019
| # issue #33370 | ||
| abstract type B33370 end | ||
|
|
||
| let n = gensym(), c(x) = B33370[x][1]() |
There was a problem hiding this comment.
For some reason I found the intent of this typed array very confusing at first sight. I think I would have been less confused by c(x) = Ref{B33370}(x)[](). Especially with a comment saying that this is to prevent type inference from determining the concrete type of x and to force a runtime method table lookup. (at least I assume this is roughly the idea.)
There was a problem hiding this comment.
Yes, the idea is to force inference to use the abstract type in its method lookup. At some point we should change all such things in our tests to something like infer_as(x, T).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate fix for #33370.